Skip to content

chore(all services): Check for incorrect url and credentials#621

Merged
ehdsouza merged 7 commits intomasterfrom
url-creds
Jan 15, 2019
Merged

chore(all services): Check for incorrect url and credentials#621
ehdsouza merged 7 commits intomasterfrom
url-creds

Conversation

@ehdsouza
Copy link
Copy Markdown
Contributor

@ehdsouza ehdsouza commented Jan 7, 2019

Users have had issues with authenticating services if they mistakenly add { or " into different fields as described in documentation. We should detect these in the first character of the username, password, apikey and service url and throw an error.

Copy link
Copy Markdown
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 8, 2019

Codecov Report

Merging #621 into master will increase coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #621      +/-   ##
=========================================
+ Coverage   37.87%   37.9%   +0.03%     
=========================================
  Files          28      28              
  Lines       19432   19446      +14     
=========================================
+ Hits         7359    7371      +12     
- Misses      12073   12075       +2
Impacted Files Coverage Δ
watson_developer_cloud/watson_service.py 77.11% <71.42%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43183da...d8e32c0. Read the comment docs.

@mediumTaj
Copy link
Copy Markdown
Contributor

@ehdsouza These tests keep failing. I separated the assistant v2 readme change to another PR. Can you take a look at this when you get back?

@ehdsouza ehdsouza merged commit ad594ec into master Jan 15, 2019
@ehdsouza ehdsouza deleted the url-creds branch January 15, 2019 18:00
@watson-github-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants