Skip to content

Conversation

@ehdsouza
Copy link
Contributor

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #693 into master will decrease coverage by 1.9%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   36.22%   34.31%   -1.91%     
==========================================
  Files          24       24              
  Lines       19194    19194              
==========================================
- Hits         6953     6587     -366     
- Misses      12241    12607     +366
Impacted Files Coverage Δ
ibm_watson/speech_to_text_v1_adapter.py 26.31% <ø> (-52.64%) ⬇️
ibm_watson/text_to_speech_adapter_v1.py 29.41% <0%> (-52.95%) ⬇️
ibm_watson/websocket/synthesize_listener.py 34.04% <0%> (-46.81%) ⬇️
ibm_watson/websocket/recognize_listener.py 24.52% <0%> (-43.4%) ⬇️
ibm_watson/websocket/audio_source.py 42.85% <0%> (-42.86%) ⬇️
...bm_watson/websocket/recognize_abstract_callback.py 52.63% <0%> (-31.58%) ⬇️
ibm_watson/websocket/synthesize_callback.py 52.94% <0%> (-17.65%) ⬇️
ibm_watson/compare_comply_v1.py 27.76% <0%> (-7.57%) ⬇️
ibm_watson/visual_recognition_v3.py 30.09% <0%> (-1.71%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d9776...05c7117. Read the comment docs.

@ehdsouza ehdsouza merged commit 7c497f9 into master Sep 27, 2019
@ehdsouza ehdsouza deleted the customization branch September 27, 2019 20:58
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 3.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants