Skip to content

fix(FileWithMetadata): Temporary changes for vr4#698

Merged
ehdsouza merged 1 commit intomasterfrom
filewithmetadata
Oct 4, 2019
Merged

fix(FileWithMetadata): Temporary changes for vr4#698
ehdsouza merged 1 commit intomasterfrom
filewithmetadata

Conversation

@ehdsouza
Copy link
Contributor

@ehdsouza ehdsouza commented Oct 4, 2019 •
edited
Loading

This gets the __str__ (), Did a test and it print this:

print(FileWithMetadata(giraffe_info))

output
{
  "data": "<_io.BufferedReader name='examples/../resources/South_Africa_Luca_Galuzzi_2004.jpeg'>"
}

@ehdsouza ehdsouza requested a review from mediumTaj October 4, 2019 17:12
mediumTaj
mediumTaj approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@ehdsouza ehdsouza merged commit 94307b3 into master Oct 4, 2019
@ehdsouza ehdsouza deleted the filewithmetadata branch October 4, 2019 17:31
@watson-github-bot
Copy link
Collaborator

watson-github-bot commented Oct 4, 2019

🎉 This PR is included in version 4.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mediumTaj mediumTaj mediumTaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready for review released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehdsouza @watson-github-bot @mediumTaj