Skip to content

Update integration tests and semantic updates#705

Merged
ehdsouza merged 9 commits intomasterfrom
sem-release
Nov 11, 2019
Merged

Update integration tests and semantic updates#705
ehdsouza merged 9 commits intomasterfrom
sem-release

Conversation

@ehdsouza
Copy link
Contributor

@ehdsouza ehdsouza commented Nov 8, 2019

This PR does the following:

  • Updates integration tests to RC instances
  • Includes examples for the ones which don't have integration tests

Also, @padamstx could you review the semantic release updates?

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #705 into master will increase coverage by 2.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #705      +/-   ##
==========================================
+ Coverage    37.8%   39.82%   +2.02%     
==========================================
  Files          24       24              
  Lines       21472    21472              
==========================================
+ Hits         8117     8551     +434     
+ Misses      13355    12921     -434
Impacted Files Coverage Δ
ibm_watson/text_to_speech_v1.py 57.34% <0%> (+0.13%) ⬆️
ibm_watson/language_translator_v3.py 63.08% <0%> (+0.14%) ⬆️
ibm_watson/personality_insights_v3.py 52.64% <0%> (+0.21%) ⬆️
ibm_watson/natural_language_classifier_v1.py 40.27% <0%> (+0.27%) ⬆️
ibm_watson/speech_to_text_v1.py 42.33% <0%> (+0.42%) ⬆️
ibm_watson/discovery_v1.py 35.3% <0%> (+0.51%) ⬆️
ibm_watson/assistant_v1.py 44.52% <0%> (+0.64%) ⬆️
ibm_watson/visual_recognition_v3.py 39.31% <0%> (+0.72%) ⬆️
ibm_watson/tone_analyzer_v3.py 38.31% <0%> (+1.89%) ⬆️
ibm_watson/visual_recognition_v4.py 39.27% <0%> (+2.36%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9d68ae...ba04e03. Read the comment docs.

Copy link

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix one thing in .releaserc

"branch": "master",
"verifyConditions": [],
"verifyConditions": ["@semantic-release/changelog", "@semantic-release/github"],
"debug": true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably don't need the "debug" field here, but also ok to leave it you want... I think it just results in more output in the travis build log

.releaserc Outdated
"verifyConditions": ["@semantic-release/changelog", "@semantic-release/github"],
"debug": true,
"prepare": [
"@semantic-release/changelog",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "exec" step needs to be done first, then changelog, then git. You can see the python-core file as an example.

@ehdsouza ehdsouza requested review from mediumTaj and padamstx and removed request for mediumTaj November 11, 2019 18:10
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@germanattanasio
Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ test/integration/test_examples.py  -1
         

See the complete overview on Codacy

@ehdsouza ehdsouza merged commit 8d8e63b into master Nov 11, 2019
@ehdsouza ehdsouza deleted the sem-release branch November 11, 2019 22:13
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants