Skip to content

Comments

Update dependencies#203

Closed
bobfang wants to merge 9 commits intowatson-developer-cloud:masterfrom
bobfang:update-dependencies
Closed

Update dependencies#203
bobfang wants to merge 9 commits intowatson-developer-cloud:masterfrom
bobfang:update-dependencies

Conversation

@bobfang
Copy link
Contributor

@bobfang bobfang commented Feb 17, 2022

Updating package dependencies to remediate whitesource scan findings

  • Using watchify to invoke browserify on the example app instead of using express-browserify (removed)
  • Added npm-run-all to run watchify and server.js for example app in local development mode (old dev script didn't exist anyway)
  • Updated mocha to latest version
  • Updated nodeify-fetch to v2.2.2
    • This broke the recognize-file should transcribe files via URL test
    • Fixed test case in recognize-file.js related to nodeify-fetch API changes between v1.0.1 to v.2.2.2
  • Removed npm from dependencies
  • Updated main package.json version to 0.39.1
  • Updated example package.json to require watson-speech ^0.39.0 so it pulls the latest available release (currently v0.39.0) and will receive update via v0.39.1 (this PR)
Checklist
  • npm test passes
  • changelog updated
Tests

Firefox 97.0 (Mac OS 10.15): Executed 42 of 42 SUCCESS (10.202 secs / 10.163 secs)
TOTAL: 42 SUCCESS

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bobfang
❌ Bob Fang


Bob Fang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bobfang bobfang closed this Feb 17, 2022
@bobfang bobfang deleted the update-dependencies branch February 17, 2022 01:05
@bobfang
Copy link
Contributor Author

bobfang commented Feb 17, 2022

had to re-do this because some commits didn't have the correct author and email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants