fix(serialization): Added en-US culture to double parsing in MiniJSON third party library #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mediumTaj
changed the title
Contributor
|
Thanks for the contribution! I need to fix one thing in the build process so I can get CI to pass. #521 Once this PR is merged in we should be able to update this branch and have passing CI. |
mediumTaj
approved these changes
Feb 21, 2019
Contributor
mediumTaj
left a comment
mediumTaj
left a comment
There was a problem hiding this comment.
👍 looks good! thank you for the contribution!
This was referenced Feb 21, 2019
Contributor
|
🎉 This PR is included in version 2.15.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue #517 fix. I had to set the culture of the TryParse method when trying to parse a float in MiniJSON because of the non-us comma format (',' instead of '.').