Skip to content

Feature remove submodule #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 1, 2019
Merged

Feature remove submodule #552

merged 9 commits into from
Apr 1, 2019

Conversation

@mediumTaj
Copy link
Contributor

@mediumTaj mediumTaj commented Apr 1, 2019

Summary

This pull request revises install instructions to download the core as a separate repo instead of a submodule. Additionally fixes were applied to examples and readme examples were corrected.

@mediumTaj mediumTaj requested a review from mamoonraja April 1, 2019 17:26
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mediumTaj
❌ semantic-release-bot
You have signed the CLA already but the status is still pending? Let us recheck it.

mamoonraja
mamoonraja approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@mamoonraja mamoonraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, left one small question.

README.md
assistant = new Assistant(credentials);
assistant.VersionDate = "2019-03-28";
assistant.ListWorkspaces(OnListWorkspaces);
assistant = new AssistantService(
Copy link
Member

@mamoonraja mamoonraja Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need AssistantService assistant in line 111 if we are defining it here too?

Copy link
Contributor Author

@mediumTaj mediumTaj Apr 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 111 is where we declare the assistant variable and 129 is where we instantiate the service.

@mediumTaj mediumTaj merged commit d53e078 into master Apr 1, 2019
@mediumTaj mediumTaj deleted the feature-remove-submodule branch April 1, 2019 19:12
@mediumTaj
Copy link
Contributor Author

mediumTaj commented Apr 1, 2019

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mamoonraja mamoonraja mamoonraja approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Ready for Review released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mediumTaj @CLAassistant @mamoonraja @semantic-release-bot