Skip to content

Conversation

@mamoonraja
Copy link
Member

@mamoonraja mamoonraja commented Oct 3, 2019

This PR:

  • Adds support for Visual Recognition V4
  • Examples for Disco, NLC and LT

To Do:

  • Migration guide.

@mamoonraja mamoonraja requested a review from mediumTaj October 3, 2019 21:36
Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, couple of questions but approving

@mediumTaj
Copy link
Contributor

Also mamoon, can you regen discovery with api def ef9010ab7de1b1fc7628a340cab118e2f00dd51d?

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs /MIGRATION-V4.md

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@mamoonraja mamoonraja merged commit 0b658a6 into 4.0.0-rc Oct 4, 2019
@mediumTaj
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants