Skip to content

Conversation

@mediumTaj
Copy link
Contributor

@mediumTaj mediumTaj commented Jul 26, 2021

Summary

This pull request removes duplicate table of contents from the readme. Additionally it removes exception that Disco V2 is only for CP4D.

@mediumTaj mediumTaj requested review from SirSpidey and kevinkowa July 26, 2021 14:30
Copy link
Contributor

@kevinkowa kevinkowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here is ok.

Grammar issue at current line 71. The Readmes don't own anything, so no '. Also, most folders don't have READMEs. And do those folders actually help people get started with the SDK? Doesn't seem obvious to me.

To get started with the Watson Services in Unity, click on each service below to read through each of their README.md's and their codes.

Should be something like this.

To get started with a Watson Service in Unity, follow the link to see the  code.

@mediumTaj
Copy link
Contributor Author

Updated per suggestion, waiting for CI

Copy link
Contributor

@SirSpidey SirSpidey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mediumTaj mediumTaj merged commit 6bdae90 into master Jul 30, 2021
@mediumTaj mediumTaj deleted the mediumTaj-patch-2 branch July 30, 2021 14:56
@watson-github-bot
Copy link
Contributor

🎉 This PR is included in version 5.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants