Skip to content

Fix: [for cherry-picking] Updated body-policy filtering to distinguish - #57

Closed
qodo-code-review[bot] wants to merge 1 commit into
ci/1747-public-repo-guard-body-scanfrom
fix/remediation-a788a2cb-e350bb
Closed

Fix: [for cherry-picking] Updated body-policy filtering to distinguish #57
qodo-code-review[bot] wants to merge 1 commit into
ci/1747-public-repo-guard-body-scanfrom
fix/remediation-a788a2cb-e350bb

Conversation

@qodo-code-review

@qodo-code-review qodo-code-review Bot commented Aug 6, 2026

Copy link
Copy Markdown

Fixed Findings

  • Fail closed on allowlist filter errors

Automated fix from agentic review of #56

Qodo Logo


Open in Devin Review

Review in cubic

Note

Fail closed on ripgrep errors in body-policy.sh filtering pipeline

The check function in body-policy.sh previously used || true to suppress all non-zero ripgrep exit codes during allowlist and control-reference filtering, meaning ripgrep errors were silently ignored.

  • Splits the single filter pipeline into two explicit steps, each capturing ripgrep's exit code in filter_rc
  • Exits with an error annotation (exit 2) if ripgrep returns exit code ≥ 2 at either step
  • Behavioral Change: scans that previously completed silently despite ripgrep errors will now fail closed with an explicit error

Macroscope summarized e129971.

@greptile-apps

greptile-apps Bot commented Aug 6, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@macroscopeapp

macroscopeapp Bot commented Aug 6, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Unable to check for correctness in e129971. This PR modifies a security guard script (public-repo-guard) with behavioral changes to error handling. The author does not own this file, and changes to security-related CI controls should be reviewed by the designated code owners (wave-av/sdk-owners).

You can customize Macroscope's approvability policy. Learn more.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants