Make architecture tests cross-target contracts - #338
Merged
Conversation
Separate compile-only target validation from native test execution by adding an explicit runner=compile metadata contract. This lets architecture fixtures validate generated artifacts on any CI host instead of being skipped when the host architecture differs from the compiler target. Add strict metadata parsing that rejects malformed, duplicate, unknown, empty, or incompatible fields. Validate build/runner coupling, host-independent compile contracts, artifact emit requirements, successful compile expectations, and RISC-V ABI architecture binding before invoking the compiler. Inspect generated ELF objects for class, machine, and RISC-V floating-point ABI flags, and inspect assembly using instruction-token matching that excludes comments, directives, and labels. Convert dormant RISC-V syscall fixtures to RV64 object and assembly contracts and make existing build-only fixtures explicit. Add permanent negative regression tests for invalid metadata, wrong ELF machine/class/ABI, and misleading assembly text. Run these tests together with Python syntax validation in every Rust and release CI architecture job.
LunaStev
marked this pull request as ready for review
August 14, 2026 09:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runner=compiletest contractWhy
The RISC-V fixtures were gated on a native RISC-V host, so most CI jobs skipped them even though Wave can cross-compile those sources. Host selection and compiler target selection are different contracts: runtime tests require a compatible host, while object and assembly checks only require the compiler to produce the requested target artifact.
This change makes that distinction explicit and verifies the generated artifact itself. It does not introduce QEMU runtime execution or linker testing; those remain follow-up work for the RISC-V Linux linking phase.
Validation
python3 -m py_compile x.py tools/run_tests.py tools/test_contracts.py tools/test_test_contracts.pypython3 -m unittest discover -s tools -p 'test_*.py'— 6 tests passedgit diff --check