fix: install.sh sha256 URL + error handling - #10
Merged
Conversation
The script built the checksum URL as <archive>.tar.gz.sha256, but taiki-e/upload-rust-binary-action uploads it as <bin>-<tag>-<target>.sha256 (without the .tar.gz). Build the right name explicitly. Also: - Capture the checksum body before piping into awk so a 404 actually errors out instead of silently producing an empty sha and a confusing "checksum mismatch (expected , got …)" message. - Rename the locals in verify_sha256 to avoid clobbering the caller's $archive (POSIX sh has no `local`); this was causing tar to receive a doubled-up path once the script got past the earlier failures. Verified end-to-end against v0.0.5 on aarch64-apple-darwin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three install.sh bugs surfaced when v0.0.5 became the first release with all assets actually attached and a real user ran the curl|sh path:
Test plan
🤖 Generated with Claude Code