feat: resumable NAR transfers (#225) - #378
Merged
Merged
Conversation
…uild_attempt cols (#225) PartialStore std::fs ran inline on the proto socket task, stalling the runtime during push bursts and hanging unrelated HTTP polls; rollup also queried build_finished_at, which the Build/BuildAttempt split moved to build_attempt.
…metrics build_attempt cols accept_chunk staged partials with blocking std::fs inline on the dispatch task; the durations heatmap queried build_finished_at/build_time_ms, which the Build/BuildAttempt split moved to build_attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225 (scope A). Adds offset-based resume for NAR transfers in both directions via additive proto messages (
NarStreamHeader/NarRequestResume/NarPushResume), on-disk.partialstaging (server keyed by peer+hash, worker by hash), a stream-token guard for uploads, and a TTL GC sweep; server-side partials also replace the in-memoryNarBuffers, retiring the #109 RAM-poison path.Per the issue owner's call, resume rests on byte offsets + the existing
file_sizelength check with no content hashing. Reconnection-continuity (B) and whole-upload-retry (C) remain follow-ups. End-to-end resume across a reconnect is covered by the NixOS VM suite in CI.