Send bot internal error message in case of errors.#545
Merged
alexeykiselev merged 2 commits intomainfrom Apr 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves bot-side observability by emitting “internal error” notifications to the bot chat when message handling or alert rendering fails, so operators can see bot/messaging failures directly in Discord/Telegram.
Changes:
- Fixes a typo in an alert deserialization error message.
- On pubsub message handling failures, generates and sends an
InternalErrorAlertto the bot. - Adds helper methods to send bot internal error messages to Discord/Telegram chats from
SendAlertMessageerror paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/messaging/alert.go | Corrects typo in “insufficient length” error message. |
| cmd/bots/internal/bots/messaging/pubsub_client.go | Sends an internal error alert to the bot when a pubsub message fails to parse/handle. |
| cmd/bots/internal/bots/environment.go | Adds sendErrMsg helpers and uses them to notify chats on alert rendering/sending errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexeykiselev
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.