feature: add configuration for notifications - #368
Merged
Gigas002 merged 2 commits intoJun 1, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 16.73% 16.61% -0.12%
==========================================
Files 20 20
Lines 3149 3171 +22
==========================================
Hits 527 527
- Misses 2622 2644 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Wait.. maybe we should just control the action of failure? Or maybe always being critical will be enough? I want to hear more opinions This part maybe good. We can ship it. But I want let another person also decide it |
Collaborator
|
+1 |
Member
|
I think I'm happy with this and we can merge, took an overall glance at the code, if you're happy with it @Decodetalkers merge it @Gigas002 |
Decodetalkers
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #334
Actual notification features differs depending on user's notification daemon, e.g. most lightweight daemons like
dunstormakodoesn't support sound playback, so the parameter doesn't have any effect.Examples: