Skip to content

feature: add configuration for notifications - #368

Merged
Gigas002 merged 2 commits into
waycrate:mainfrom
Gigas002:feature/notification-configuration
Jun 1, 2026
Merged

feature: add configuration for notifications#368
Gigas002 merged 2 commits into
waycrate:mainfrom
Gigas002:feature/notification-configuration

Conversation

@Gigas002

Copy link
Copy Markdown
Member

Closes: #334

Actual notification features differs depending on user's notification daemon, e.g. most lightweight daemons like dunst or mako doesn't support sound playback, so the parameter doesn't have any effect.

Examples:

image image

@codecov-commenter

codecov-commenter commented May 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.61%. Comparing base (7112e6c) to head (cafbe88).

Files with missing lines Patch % Lines
wayshot/src/notification.rs 0.00% 36 Missing ⚠️
wayshot/src/wayshot.rs 0.00% 2 Missing ⚠️
wayshot/src/settings.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   16.73%   16.61%   -0.12%     
==========================================
  Files          20       20              
  Lines        3149     3171      +22     
==========================================
  Hits          527      527              
- Misses       2622     2644      +22     
Flag Coverage Δ
libwayshot 22.05% <ø> (ø)
wayshot 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread config.toml Outdated
Comment thread wayshot/src/notification.rs
@Decodetalkers

Decodetalkers commented May 16, 2026

Copy link
Copy Markdown
Collaborator

Wait.. maybe we should just control the action of failure? Or maybe always being critical will be enough? I want to hear more opinions

This part maybe good. We can ship it. But I want let another person also decide it

@Decodetalkers

Copy link
Copy Markdown
Collaborator

+1

@Shinyzenith

Copy link
Copy Markdown
Member

I think I'm happy with this and we can merge, took an overall glance at the code, if you're happy with it @Decodetalkers merge it @Gigas002

@Gigas002
Gigas002 merged commit 7a01e07 into waycrate:main Jun 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

feature request: consider providing configuration for notifications

4 participants