user registration: handle accepted policies#1187
Open
deer-wmde wants to merge 7 commits into
Open
Conversation
deer-wmde
force-pushed
the
accept_policies
branch
from
2218455 to
2fcfbfe
Compare
deer-wmde
changed the title
dati18
requested changes
Jul 10, 2026
dati18
left a comment
dati18
left a comment
Contributor
There was a problem hiding this comment.
I helped out a bit to figure out why test failed
| use App\UserTermsOfUseAcceptance; | ||
| use App\Policy; | ||
| use App\PolicyAcceptance; | ||
| use App\TermsOfUseVersion |
Contributor
There was a problem hiding this comment.
missng a ;
Suggested change
| use App\TermsOfUseVersion | |
| use App\TermsOfUseVersion; |
| ]); | ||
|
|
||
| // accept latest Terms of Use Policy automatically | ||
| $latestToU = TermsOfUseVersion::latestActiveVersion(); |
Contributor
There was a problem hiding this comment.
references to classes that have been deleted since T430532
You can remove it entirely
| @@ -12,11 +16,12 @@ class UserCreateJob extends Job { | |||
|
|
|||
| private $verified; | |||
Contributor
There was a problem hiding this comment.
$this->acceptedPolicyIds assigned in constructor with no property declaration
Suggested change
| private $verified; | |
| private $verified; | |
| private $acceptedPolicyIds; | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T430525