feat(ci): automatically update image version in wbaas-deploy on tagged release#614
Conversation
| labels: ${{ steps.docker_meta.outputs.labels }} | ||
|
|
||
| - | ||
| name: Check whether wbaas-deploy should be updated |
There was a problem hiding this comment.
An alternative to doing this check and then skipping the following steps would be to stop releasing latest when pushing to main which I think we don't ever use anywhere anyways?
There was a problem hiding this comment.
yeah, we don't use it anyway either AFAICT; I believe we should therefore feel free to remove it.
There was a problem hiding this comment.
One detail I missed yesterday: this would also mean we stop building the image on Pull Requests for the purpose of "testing whether this still builds". I could live with that, but wanted to double check.
There was a problem hiding this comment.
ah, yeah. I believe we definitely want to check this builds on each PR (otherwise there is a high chance of us merging non-building code).
One alternative if you wanted to refactor more heavily would be to:
- stick these following steps in their own job.
- Make this job dependent on the build job running (https://docs.github.com/en/actions/using-jobs/using-jobs-in-a-workflow#example-requiring-successful-dependent-jobs)
- using a condition on the job to ensure it only runs on tags that exist on
main(https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution)
df6f8a6 to
dedc75a
Compare
|
This needs a powerful person that can set |
|
A token is now added to this repo. |
tarrow
left a comment
tarrow
left a comment
There was a problem hiding this comment.
Would be happy to see merged as is or to review again if you prefer to think about some alterations after reading the one comment thread
2 participants
Ticket https://phabricator.wikimedia.org/T340039
This works slightly differently than in UI as we still need to push a tag before a release happens.