Ensure that report helper is called when a batch is failed#696
Merged
Conversation
m90
force-pushed
the
fr/failed-batch-report
branch
from
November 28, 2023 12:45
8528ee5 to
ae92c01
Compare
m90
force-pushed
the
fr/failed-batch-report
branch
from
November 28, 2023 12:58
ae92c01 to
9d4f7fe
Compare
m90
commented
Nov 28, 2023
m90
commented
Nov 28, 2023
| ])->get()->pluck('id'); | ||
| QsBatch::whereIn('id', $failedBatches)->update(['failed' => true]); | ||
| }); | ||
| foreach ($failedBatches as $batchId) { |
Contributor
Author
There was a problem hiding this comment.
I moved this out of the transaction so we know everything has been committed before we send out the errors.
m90
force-pushed
the
fr/failed-batch-report
branch
from
November 28, 2023 15:25
0a0b470 to
d767e74
Compare
tarrow
approved these changes
Nov 28, 2023
tarrow
left a comment
tarrow
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this was super easy to read and review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deploying #685 I noticed failed batches would not be reported.
It seems
tapdoes not work as I thought it would be and instead of giving us the updated models down the chain, it would re-evaluate the query, yielding 0 results on->get()as the update just happened and nothing matches the query anymore.Instead, we can query for candidate ids, update these in a second query and then report.