Requeueing should not select failed batches#698
Merged
Merged
Conversation
m90
force-pushed
the
fr/failed-requeue
branch
2 times, most recently
from
November 29, 2023 08:33
b38485e to
a69ab45
Compare
m90
force-pushed
the
fr/failed-requeue
branch
from
November 29, 2023 08:37
a69ab45 to
74bb13f
Compare
m90
force-pushed
the
fr/failed-requeue
branch
from
November 29, 2023 09:18
74bb13f to
0fffc64
Compare
m90
commented
Nov 29, 2023
| ->increment( | ||
| 'processing_attempts', 1, | ||
| ['pending_since' => null, 'done' => 0] | ||
| ['pending_since' => null, 'done' => false] |
Contributor
Author
There was a problem hiding this comment.
This is just a stylistic change so that the class always uses true|false instead of true|false|0|1
tarrow
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, failed jobs will still be selected by the query for requeuing, creating an incorrect number of processing attempts.
This has no user facing effect, but can be confusing when debugging.