Skip to content

fix: edit items in place when stripping prefixes, do not use regex #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m90 merged 2 commits into from
Dec 13, 2023
Merged

fix: edit items in place when stripping prefixes, do not use regex #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4104b0
fix: edit items in place when stripping prefixes, do not use regex
Dec 13, 2023
221fd33
docs: add changelog
Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
# api

## 8x.28.11 - 12 December 2023
- Batches that are done shall never be marked failed
## 8x.29.1 - 13 December 2023
- Try to fix memory exhaustion issue when running wbs-qs:rebuild command

## 8x.29.0 - 13 December 2023
- Add command for rebuilding Queryservice data

## 8x.28.11 - 12 December 2023
- Batches that are done shall never be marked failed

## 8x.28.10 - 29 November 2023
- Requeueing should not select failed batches

Expand Down
12 changes: 7 additions & 5 deletions app/Console/Commands/RebuildQueryserviceData.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ private function getEntitiesForWiki (Wiki $wiki): array
: [];

$merged = array_merge($items, $properties, $lexemes);
return $this->stripPrefixes($merged);
$this->stripPrefixes($merged);
return $merged;
}

private function getSparqlUrl (Wiki $wiki): string
Expand Down Expand Up @@ -154,10 +155,11 @@ private function fetchPagesInNamespace(string $wikiDomain, int $namespace): arra
return $titles;
}

private static function stripPrefixes (array $items): array
private static function stripPrefixes (array &$items): void
{
return array_map(function (string $item) {
return preg_replace('/^[a-zA-Z]+:/', '', $item);
}, $items);
foreach ($items as &$item) {
$e = explode(':', $item);
$item = end($e);
}
}
}