fix(qs-batches): retry running transactions that require db locks#736
Merged
Conversation
tarrow
approved these changes
Feb 7, 2024
tarrow
left a comment
tarrow
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me; I also glanced at the other 4 DB::transaction calls in this repo and I don't think this retry behaviour immediately needs to be added there
Contributor
Author
Yup, I would think we only need to retry when we actually lock. Else, the failure is very unlikely to succeed on second attempt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fixup for #721
Apparently transactions that cannot acquire a lock now fail (which is expected), so we should retry them afterwards a couple of times before giving up. Laravel's
DB::transactioncan do this for us.