fix: Fix crash on React Native 0.83+#295
Closed
wojtekmaj wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash occurring on React Native 0.83+ by updating the method used to retrieve bounding rectangles. React Native 0.83+ removed the unstable_getBoundingClientRect() method in favor of the stable getBoundingClientRect() API.
Key Changes:
- Replaced platform-specific checks with a feature detection approach to determine which bounding rectangle method to use
- Simplified code by removing TypeScript error suppressions and multiple conditional branches
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
noo sorry I hadn't seen this PR, my apologies. I hope it's ok. just saw it now. |
Author
|
No worries William! Thank you for your hard work on this package. <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294