Skip to content

python: remove support for Boost::python#34

Merged
davvid merged 3 commits intomainfrom
python
Apr 2, 2026
Merged

python: remove support for Boost::python#34
davvid merged 3 commits intomainfrom
python

Conversation

@davvid
Copy link
Copy Markdown
Member

@davvid davvid commented Mar 30, 2026

We no longer support USD < 25.11. Remove dead code.

Resolves: PUP-3206

We no longer support USD < 25.11. Remove dead code.

Resolves: PUP-3206
@davvid
Copy link
Copy Markdown
Member Author

davvid commented Mar 31, 2026

Ah, it's interesting that the tests have issues on 25.11 only. If we'd like to handle that separately I could adjust the CI configs to omit 25.11 for now until we have a chance to investigate that. Let me know if you're okay with that approach.

@buddly27
Copy link
Copy Markdown
Contributor

Ah, it's interesting that the tests have issues on 25.11 only. If we'd like to handle that separately I could adjust the CI configs to omit 25.11 for now until we have a chance to investigate that. Let me know if you're okay with that approach.

I think the failing test might be linked to this commit PixarAnimationStudios/OpenUSD@845f08c in v25.08.

From the CHANGELOG:

UsdStage will now dispatch finer grained change notifications for sublayer operations such as sublayer insertion/removal and layer muting/unmuting. This feature can be toggled via the PCP_ENABLE_MINIMAL_CHANGES_FOR_LAYER_OPERATIONS env var (default is on).

It could be worth toggling that env var to confirm whether it resolves the issue, but we’ll likely need to update the tests to align with the new behavior.

@davvid
Copy link
Copy Markdown
Member Author

davvid commented Mar 31, 2026

PCP_ENABLE_MINIMAL_CHANGES_FOR_LAYER_OPERATIONS

It could be worth toggling that env var to confirm whether it resolves the issue, but we’ll likely need to update the tests to align with the new behavior.

Sounds good. I'll take a stab at setting this variable to 0 tomorrow as a first step.

@davvid
Copy link
Copy Markdown
Member Author

davvid commented Mar 31, 2026

I've added a new commit that enables all of the newer USD versions alongside a change that sets the environment variable to 0 for now. Let's see if these pass now.

The version matrix is larger now, but we can trim it down in a subsequent change once we remove the variable and adapt the tests to the new expected behavior.

@buddly27
Copy link
Copy Markdown
Contributor

buddly27 commented Apr 1, 2026

Thanks! The tests are passing now.

The version matrix is larger now, but we can trim it down in a subsequent change once we remove the variable and adapt the tests to the new expected behavior.

Actually, since we are deprecating USD support under 25.11, we could drop v25.05 and v25.08 from the list

Temporarily disable the updated PCP change notifications
to keep the tests passing. The tests will be adapted to
the new behavior without the environment variable in an
upcoming change.
@davvid
Copy link
Copy Markdown
Member Author

davvid commented Apr 1, 2026

Actually, since we are deprecating USD support under 25.11, we could drop v25.05 and v25.08 from the list

Done. The latest commit now includes just 25.11 and 26.03.

Copy link
Copy Markdown
Contributor

@buddly27 buddly27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks David!

@davvid davvid merged commit 39ccf71 into main Apr 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants