This repository was archived by the owner on Jun 20, 2024. It is now read-only.
[proxy] Symlink sockets to /var/run/weave/weave.sock from inside the proxy#1740
Merged
[proxy] Symlink sockets to /var/run/weave/weave.sock from inside the proxy#1740
Conversation
…proxy We copy docker.sock owner to symlinks. Permissions are not copied, because the permissions will inherit from the target. use versioned exec image to create symlinks
proxy/proxy.go
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
prog/weaveexec/symlink
Outdated
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
paulbellamy
force-pushed
the
1694-symlink-into-var-run-2
branch
from
4a4a91d to
ac1cf63
Compare
awh
added a commit
that referenced
this pull request
Dec 2, 2015
Symlink sockets to /var/run/weave/weave.sock from inside the proxy
Contributor
|
Does this fix #1579 ? |
Contributor
Author
|
I believe so, yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs an in-depth review, please.
We copy docker.sock owner to symlinks. Permissions are not copied,
because the permissions will inherit from the target.
Fixes #1694, using option 2 (having the proxy create the symlinks). If the weave script creates the symlinks,
weave envwould break (unless we passed the symlinks in, and that's awkward).There is a slight change in behaviour of
weave env. New order of preference is: tcp sockets, custom unix sockets, then/var/run/weave/weave.sock.Most of the awkwardness/code in this is just to run a docker container. 😞
Happy to refactor, any suggestions on ways to clean up the code would be great.