docs: correct deprecated ChunkSize and document backup chunking variables#473
Open
g-despot wants to merge 1 commit into
Open
docs: correct deprecated ChunkSize and document backup chunking variables#473g-despot wants to merge 1 commit into
g-despot wants to merge 1 commit into
Conversation
…bles ChunkSize has had no effect since its removal in core, but the page documented it as a working option with a default, minimum and maximum. Mark it deprecated and point to BACKUP_CHUNK_TARGET_SIZE. Document BACKUP_MIN_CHUNK_SIZE, BACKUP_CHUNK_TARGET_SIZE and BACKUP_SPLIT_FILE_SIZE, which were undocumented, including how their values are raised against each other. Document the location parameter for text2vec-google. No version markers: these all landed across several stable lines, so no single version is correct for every supported release.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes documentation that is wrong or missing for users on current releases. No 1.39 content.
ChunkSizewas documented as a working backup option with a default, minimum and maximum. It has had no effect since it was removed in core (present as deprecated in v1.38.5 and every supported line). Now marked deprecated, pointing atBACKUP_CHUNK_TARGET_SIZE.BACKUP_MIN_CHUNK_SIZE,BACKUP_CHUNK_TARGET_SIZEandBACKUP_SPLIT_FILE_SIZEwere undocumented. Added, with a note on how their values are raised against each other.text2vec-googlegained alocationparameter that was never documented. Optional, defaults tous-central1.No version markers anywhere: each of these landed across several stable lines, so no single version is correct for every supported release.
Site build passes.