Skip to content

Fix return type PHPDoc in Algorithm/Manager#1

Merged
Spomky merged 1 commit intoweb-auth:v4.0from
TimWolla:patch-1
Jun 17, 2022
Merged

Fix return type PHPDoc in Algorithm/Manager#1
Spomky merged 1 commit intoweb-auth:v4.0from
TimWolla:patch-1

Conversation

@TimWolla
Copy link
Copy Markdown
Contributor

Not sure if this is the correct place to put my PR, but the cose-lib is no longer part of the main repository.

@Spomky Spomky merged commit 61c967e into web-auth:v4.0 Jun 17, 2022
@TimWolla TimWolla deleted the patch-1 branch June 17, 2022 14:45
@Spomky
Copy link
Copy Markdown
Contributor

Spomky commented Jun 17, 2022

Many thanks.
Yes this is the good place. I decoupled the libraries from webauthn repository as there is not much modifications but versions were still going up (for no reason).

@TimWolla
Copy link
Copy Markdown
Contributor Author

TimWolla commented Jun 17, 2022

Yes this is the good place. I decoupled the libraries from webauthn repository as there is not much modifications but versions were still going up (for no reason).

Okay, then you should delete https://github.com/web-auth/cose-lib/blob/v4.0/.github/PULL_REQUEST_TEMPLATE.md and also update the repository description to remove the [READ ONLY].

Also, thanks for creating the WebAuthn framework!

@Spomky
Copy link
Copy Markdown
Contributor

Spomky commented Jun 27, 2022

Hi @TimWolla,

It will be settled.
I will add issue/PR templates and other necessary files.

Regards.

@Spomky
Copy link
Copy Markdown
Contributor

Spomky commented Jul 16, 2022

Done. Project files added/changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants