Remove WebDriver implicit session creation #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnedders
changed the title
jgraham
reviewed
Jun 3, 2025
Contributor
jgraham
left a comment
jgraham
left a comment
There was a problem hiding this comment.
I think this should be fine; I'd probably want to run the patch against Gecko CI before landing, just in case any of our internal tests are doing anything unexpected.
Co-authored-by: jgraham <james@hoppipolla.co.uk>
Member
Author
|
This RFC is now three weeks old, and it was briefly discussed in the meeting with rough support from @jgraham (see also above) and @jcscottiii; is there anything blocking this from getting approved? |
jgraham
approved these changes
Jun 5, 2025
Contributor
jgraham
left a comment
jgraham
left a comment
There was a problem hiding this comment.
This seemed to be fine in our CI, so no objections here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered.
See also web-platform-tests/wpt#51845 and web-platform-tests/wpt#51868.