Auto-update the webrtc IDL file#11700
Merged
foolip merged 5 commits intoAug 3, 2018
Merged
Conversation
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
dontcallmedom,
guidou,
henbos,
phoglund,
rwaldron,
snuggs and
youennf
lukebjerring
force-pushed
the
idl-file-updates-webrtc
branch
2 times, most recently
from
3ccd194 to
87b2d2a
Compare
Contributor
Author
|
To see the changes to the IDL itself, they're shown in the separated commit here: GitHub seems to not be able to aggregate the rename and updates in the full overview. |
lukebjerring
force-pushed
the
idl-file-updates-webrtc
branch
from
87b2d2a to
cafda08
Compare
lukebjerring
force-pushed
the
idl-file-updates-webrtc
branch
from
cafda08 to
b5535b8
Compare
Member
|
Filed w3c/webref#15 about the missing space you had to put back. |
foolip
pushed a commit
that referenced
this pull request
Aug 2, 2018
When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See #11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation).
foolip
force-pushed
the
idl-file-updates-webrtc
branch
from
b5535b8 to
b7c5e89
Compare
lukebjerring
force-pushed
the
idl-file-updates-webrtc
branch
from
b7c5e89 to
8f61c21
Compare
lukebjerring
added a commit
to lukebjerring/wpt
that referenced
this pull request
Aug 2, 2018
…2272) When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See web-platform-tests#11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation).
Member
|
Some commits have gotten included on this PR by accident, I'll rebase to get rid of them. |
foolip
force-pushed
the
idl-file-updates-webrtc
branch
from
f8579f2 to
242143d
Compare
foolip
approved these changes
Aug 3, 2018
Member
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
Tested locally in Chrome and Firefox and compared to http://web-platform-tests.live/webrtc/interfaces.https.html.
There are much more subtests now, 494 instead of 18, and lots are failing, but skimming through the failures they mostly look the kinds of things in the WebRTC spec that haven't been implemented yet.
There are probably a few bugs left in this very complex test setup, but this is a huge improvement!
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 4, 2018
… better, a=testonly Automatic update from web-platform-tests[idlharness.js] Catch IdlArray.test bugs better (#12272) When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See web-platform-tests/wpt#11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation). -- wpt-commits: e9f3244421c353a63142dd9742e0ed6edc509cc8 wpt-pr: 12272
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Aug 4, 2018
… better, a=testonly Automatic update from web-platform-tests[idlharness.js] Catch IdlArray.test bugs better (#12272) When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See web-platform-tests/wpt#11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation). -- wpt-commits: e9f3244421c353a63142dd9742e0ed6edc509cc8 wpt-pr: 12272
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
… better, a=testonly Automatic update from web-platform-tests[idlharness.js] Catch IdlArray.test bugs better (#12272) When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See web-platform-tests/wpt#11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation). -- wpt-commits: e9f3244421c353a63142dd9742e0ed6edc509cc8 wpt-pr: 12272 UltraBlame original commit: 903bfa6c1528b6ece9c646c773cf48849743690b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
… better, a=testonly Automatic update from web-platform-tests[idlharness.js] Catch IdlArray.test bugs better (#12272) When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See web-platform-tests/wpt#11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation). -- wpt-commits: e9f3244421c353a63142dd9742e0ed6edc509cc8 wpt-pr: 12272 UltraBlame original commit: 903bfa6c1528b6ece9c646c773cf48849743690b
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
… better, a=testonly Automatic update from web-platform-tests[idlharness.js] Catch IdlArray.test bugs better (#12272) When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See web-platform-tests/wpt#11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation). -- wpt-commits: e9f3244421c353a63142dd9742e0ed6edc509cc8 wpt-pr: 12272 UltraBlame original commit: 903bfa6c1528b6ece9c646c773cf48849743690b
gcp
pushed a commit
to gcp/enterprise-firefox-old
that referenced
this pull request
Feb 17, 2026
… better, a=testonly Automatic update from web-platform-tests[idlharness.js] Catch IdlArray.test bugs better (#12272) When a bug exists in `IdlArray.test`, `idl_test`'s `catch` flow is incorrectly re-attempting to run the tests (causing a double-up of the tests). See web-platform-tests/wpt#11700. This changes the flow to call `IdlArray.test` in a `finally` (regardless of whether any setup errors have occurred), preventing the possibility of double-ups when bugs in `IdlArray.test` occur. Also fixes the bug that highlighted this problem (passing a `null` object when the interface contains a `toJSON` operation). -- wpt-commits: e9f3244421c353a63142dd9742e0ed6edc509cc8 wpt-pr: 12272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/directory (instead of inline copies in the test files).