[Gecko Bug 1910352] Ensure keyUp/keyDown value it one grapheme cluster #47508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return InvalidArgumentError if the action value for key actions is not exactly one grapheme cluster long. Supporting full grapheme clusters rather than just single codepoints is marked as TODO in the spec, so add tentative tests for that. Differential Revision: https://phabricator.services.mozilla.com/D217950 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1910352 gecko-commit: b39c4bd4277c4e2c1b82762f4d1fb8a5bbc34ea3 gecko-reviewers: webdriver-reviewers, jdescottes
wpt-pr-bot
approved these changes
Aug 7, 2024
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return InvalidArgumentError if the action value for key actions is
not exactly one grapheme cluster long.
Supporting full grapheme clusters rather than just single codepoints
is marked as TODO in the spec, so add tentative tests for that.
Differential Revision: https://phabricator.services.mozilla.com/D217950
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1910352
gecko-commit: b39c4bd4277c4e2c1b82762f4d1fb8a5bbc34ea3
gecko-reviewers: webdriver-reviewers, jdescottes