Improve TT tests for SVG and HTML script innerHTML #50442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
force-pushed
the
trusted-types-svg-script-fixes
branch
from
aa9921e to
9eee087
Compare
fred-wang
approved these changes
Feb 3, 2025
Contributor
fred-wang
left a comment
fred-wang
left a comment
There was a problem hiding this comment.
This looks ok, but I believe you can now really just copy
with createElement("div") replaced with createElementNS(NSURI_SVG, "script") (and use support/namespaces.js).
That will exercise clipping of sample.
lukewarlow
force-pushed
the
trusted-types-svg-script-fixes
branch
from
9eee087 to
d18c8bc
Compare
fred-wang
approved these changes
Feb 3, 2025
Contributor
fred-wang
left a comment
fred-wang
left a comment
There was a problem hiding this comment.
Thanks, these newer tests are better indeed.
lukewarlow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous tests were wrong and don't pass in either of the two implementations (Chromium or WebKit).
SVGScriptElement is intended to behave as close to HTMLScriptElement as possible and innerHTML doesn't work differently for HTMLScriptElement compared with other elements.