constellation: Only return focused browsing contexts that exist. #51848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Apr 4, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_36330
branch
2 times, most recently
from
ffbc26e to
6f5b130
Compare
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
servo-wpt-sync
force-pushed
the
servo_export_36330
branch
from
6f5b130 to
94ec3d3
Compare
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#36330), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
servo-wpt-sync
added
the
stale-servo-export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webdriver server relies on the constellation to report which browsing context is focused, and assumes that a focused context is ready for interaction. However, new browsing contexts exist in a weird state where they are not tracked by the constellation until the initial load is complete, which leads to the constellation rejecting attempts to navigate a browsing context right after it's created. These changes ensure the constellation does not report a browsing context as focused until it's actually created and ready for interaction.
Testing: Run
./mach test-wpt --product servodriver tests/wpt/mozilla/tests/mozilla/DOMParser.html, which now runs to completion.Fixes: #34551
Fixes: #36328
Reviewed in servo/servo#36330