-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New Session tests should handle more default browser capabilities #52415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Session tests should handle more default browser capabilities #52415
Conversation
karlcow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not fully sure about the del statement there.
whimboo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ensure that each test only verifies the specific behavior indicated by its name.
I presume these use We certainly can remove |
1b0c69b to
a9c2bb6
Compare
whimboo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. Thank you for the explanation. So lets apply the following suggestion to the relevant tests to make it clearer.
This ensures test_merge_platform_name and test_merge_browserName both work even when a platformName and browserName capability is provided in the default capabilities. And while we're fixing that, also fix the case that pageLoadStrategy is provided.
a9c2bb6 to
672067b
Compare
This ensures test_merge_platform_name and test_merge_browserName both
work even when a platformName and browserName capability is provided
in the default capabilities. And while we're fixing that, also fix the
case that pageLoadStrategy is provided.