[testdriver] Expose BiDi browsingContext.setViewport to regular WPT tests#59265
Open
Minju-kim-igalia wants to merge 6 commits intoweb-platform-tests:masterfrom
Open
[testdriver] Expose BiDi browsingContext.setViewport to regular WPT tests#59265Minju-kim-igalia wants to merge 6 commits intoweb-platform-tests:masterfrom
Minju-kim-igalia wants to merge 6 commits intoweb-platform-tests:masterfrom
Conversation
…ests This change exposes the existing BiDi `browsingContext.setViewport` command to regular WPT tests through `testdriver.js?feature=bidi`. It adds a thin `test_driver.bidi.browsing_context.set_viewport(...)` wrapper and the corresponding wptrunner plumbing so testharness-based tests can set a viewport and/or `devicePixelRatio` override from the page. This patch also adds a small DPR-focused WPT under `css/cssom-view/` that verifies: - `window.devicePixelRatio` reflects the override - `resolution` media queries reflect the override Testing:`./wpt run chrome css/cssom-view/devicepixelratio-override-bidi.https.html - Ref web-platform-tests#12725 - Chromium: https://issues.chromium.org/issues/489737943
wpt-pr-bot
added
cssom-view
infra
testdriver.js
wg-s_css
wptrunner
wpt-pr-bot
requested review from
AutomatedTester,
DanielRyanSmith,
foolip,
jgraham,
jonathan-j-lee and
plinss
Contributor
Author
There was a problem hiding this comment.
Added Firefox metadata for the new test.
Firefox currently reports Unknown action bidi.browsing_context.set_viewport from the Marionette executor, so I marked this as expected ERROR for now.
Would it be OK to keep this expectation for now and handle Marionette executor support as follow-up work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes the existing BiDi
browsingContext.setViewportcommand to regular WPT tests throughtestdriver.js?feature=bidi. It adds a thintest_driver.bidi.browsing_context.set_viewport(...)wrapper and the corresponding wptrunner plumbing so testharness-based tests can set a viewport and/ordevicePixelRatiooverride from the page.This patch also adds a small DPR-focused WPT under
css/cssom-view/that verifies:window.devicePixelRatioreflects the overrideresolutionmedia queries reflect the overrideTesting:
./wpt run chrome css/cssom-view/devicepixelratio-override-bidi.https.html