Remove redundant ext-json requirement - #462
Merged
Minishlink merged 1 commit intoSep 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the redundant
ext-jsonComposer requirement.PHP JSON has been part of core since PHP 8.0 and cannot be disabled, while this package already requires PHP >= 8.2. Keeping
ext-jsoninrequiretherefore adds no compatibility protection.Verification:
composer validate --strict --no-check-publish— passcomposer test:typing— pass (0 errors)composer test:syntax— passcomposer test:syntax_tests— passgit diff --check— passcomposer test:unit_offlinestill reports the same pre-existing data-provider error reproduced on upstreammasterbefore this change: 44 tests, 110 assertions, 1 error, 6 skipped (Subscription::__construct()receivesfalsefor the endpoint). This patch does not change that result.AI assistance was used to help prepare and verify this contribution; the final one-line change and verification results were reviewed directly.
Fixes #461.