Skip to content

Remove redundant ext-json requirement - #462

Merged
Minishlink merged 1 commit into
web-push-libs:masterfrom
asllanmaciel:fix/461-remove-ext-json
Sep 9, 2026
Merged

Remove redundant ext-json requirement#462
Minishlink merged 1 commit into
web-push-libs:masterfrom
asllanmaciel:fix/461-remove-ext-json

Conversation

@asllanmaciel

Copy link
Copy Markdown
Contributor

Removes the redundant ext-json Composer requirement.

PHP JSON has been part of core since PHP 8.0 and cannot be disabled, while this package already requires PHP >= 8.2. Keeping ext-json in require therefore adds no compatibility protection.

Verification:

  • composer validate --strict --no-check-publish — pass
  • composer test:typing — pass (0 errors)
  • composer test:syntax — pass
  • composer test:syntax_tests — pass
  • git diff --check — pass
  • composer test:unit_offline still reports the same pre-existing data-provider error reproduced on upstream master before this change: 44 tests, 110 assertions, 1 error, 6 skipped (Subscription::__construct() receives false for the endpoint). This patch does not change that result.

AI assistance was used to help prepare and verify this contribution; the final one-line change and verification results were reviewed directly.

Fixes #461.

@Minishlink Minishlink left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Minishlink
Minishlink merged commit af29c4d into web-push-libs:master Sep 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant ext-json requirement should be removed

2 participants