Cosmos plugin environment subscribe command#291
Merged
evgheni7 merged 2 commits intoMar 31, 2025
Conversation
2 tasks
evgheni7
requested changes
Mar 31, 2025
| logger := zap.NewExample().Sugar() | ||
| defer logger.Sync() | ||
|
|
||
| u := url.URL{Scheme: "ws", Host: "0.0.0.0:26657", Path: "/websocket"} |
Contributor
There was a problem hiding this comment.
@Catalin4513 use parameters and variables for host,port and path.
Catalin4513
force-pushed
the
263-featenv-auto-create-environment-by-network-event
branch
from
ab42e8f to
94ebe63
Compare
evgheni7
requested changes
Mar 31, 2025
| Namespace string `name:"namespace" short:"n" help:"Namespace used for cluster resources"` | ||
| EngineRelease string `name:"engine-release" short:"r" help:"Crossplane Helm release name"` | ||
| EngineVersion string `name:"engine-version" default:"1.19.0" short:"v" help:"Crossplane version"` | ||
| PluginPath string `name:"plugin-path" help:"Path to the plugin file" default:"./plugins/cosmos.so"` |
Contributor
There was a problem hiding this comment.
@Catalin4513 shall be default value where plugins stored, but not single plugin file.
Contributor
There was a problem hiding this comment.
@Catalin4513 was idea of fully dynamic plugins, even not stored in this repository, just make it look to directory and load all .so files from there.
| ) | ||
|
|
||
| type CLI struct { | ||
| Network network.Cmd `cmd:"" help:"Network information"` |
Contributor
There was a problem hiding this comment.
@Catalin4513 I another plugin will have also Network command what's happens?
Idea was that every plugin adds own commands namespace, like Cosmos
| @@ -0,0 +1,18 @@ | |||
| package network | |||
Comment on lines
+156
to
+158
| if engine == "" { | ||
| engine = "k3s" | ||
| } |
Contributor
There was a problem hiding this comment.
@Catalin4513 you do not need this condition if you have default value, and on cmd level it shall be k3s, we do not support kind in case of networks at all.
Comment on lines
+96
to
+107
| result, ok := decodedMessage["result"].(map[string]interface{}) | ||
| if !ok { | ||
| log.Println("Skipping message: 'result' field is missing") | ||
| return msgStruct, fmt.Errorf("'result' field is missing") | ||
| } | ||
|
|
||
| data, ok := result["data"].(map[string]interface{}) | ||
| if !ok { | ||
| log.Println("Skipping message: 'data' field is missing") | ||
| return msgStruct, fmt.Errorf("'data' field is missing") | ||
| } | ||
|
|
||
| value, ok := data["value"].(map[string]interface{}) | ||
| if !ok { | ||
| log.Println("Skipping message: 'value' field is missing") | ||
| return msgStruct, fmt.Errorf("'value' field is missing") | ||
| } | ||
|
|
||
| txResult, ok := value["TxResult"].(map[string]interface{}) | ||
| if !ok { | ||
| log.Println("Skipping message: 'TxResult' field is missing") | ||
| return msgStruct, fmt.Errorf("'TxResult' field is missing") | ||
| } | ||
|
|
||
| transaction, ok := txResult["tx"].(string) | ||
| if !ok { | ||
| log.Println("Skipping message: 'tx' field is missing or not a string") | ||
| return msgStruct, fmt.Errorf("'tx' field is missing or not a string") | ||
| } | ||
|
|
||
| txBytes, err := base64.StdEncoding.DecodeString(transaction) | ||
| if err != nil { | ||
| log.Printf("Failed to decode base64: %v", err) | ||
| return msgStruct, err | ||
| } |
Contributor
There was a problem hiding this comment.
@Catalin4513 is not good idea to direct convert fields, use unmarshal to ready to use structure and use validation package for structures for simplify code, take a look to repository package, there validation was used.
evgheni7
changed the title
Catalin4513
force-pushed
the
263-featenv-auto-create-environment-by-network-event
branch
from
94ebe63 to
912e3e1
Compare
evgheni7
approved these changes
Mar 31, 2025
evgheni7
deleted the
263-featenv-auto-create-environment-by-network-event
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.