Conversation
kalwalt
added
🚀 enhancement
- updating license date - improving JSDoc descriptions and fixing various typos in docs and in some examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the documentation, update dependencies, and enhance the codebase for better performance and readability. The most important changes include updating the Node.js version requirement, fixing typos, adding new examples, updating dependencies, and enhancing type safety and code clarity.
Documentation Updates:
CONTRIBUTING.md: Updated the Node.js version requirement from v14 to v20.README.md: Fixed a typo in the example file name and added a new example for.zftfiles. [1] [2] [3]Example Enhancements:
examples/arNFT_gltf_flamingo_example.html: Addedlang="en"to the HTML tag and replacedvarwithconstfor better type safety. [1] [2]examples/arNFT_initialize_raw_example.html: Addedlang="en"to the HTML tag and replacedvarwithconstfor better type safety. [1] [2]examples/arNFT_simd_example.html: Addedlang="en"to the HTML tag and replacedvarwithconstfor better type safety. [1] [2]examples/arNFT_zft_example.html: Added a new example file for.zftfiles.Dependency Updates:
package.json: Updated multiple dependencies including@types/node,prettier,typedoc,typescript,webpack,@webarkit/jsartoolkit-nftand@webarkit/oneeurofilter-ts. [1] [2]Code Enhancements:
src/ARnft.simd.ts: Improved type safety by replacingvarwithconst, added detailed JSDoc comments, and fixed minor typos. [1] [2] [3] [4] [5] [6] [7] [8] [9]