improves to viewMatrix_GL and related code#32
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
WebARKitmodule, focusing on improving the handling of matrix computations and logging. The most important changes include modifying matrix initialization, adding new methods for matrix computation, and enhancing logging for debugging purposes.Matrix computation improvements:
WebARKit/WebARKitPattern.cpp: Changed the initialization ofglViewMatrixto useCV_64FC1for consistency withpose3d.WebARKit/WebARKitPattern.cppandWebARKit/include/WebARKitPattern.h: Added a new overloaded methodcomputeGLviewMatrixthat accepts acv::Matparameter to compute the GL view matrix using a given pose. [1] [2]Logging enhancements:
WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp: Added logging for the camera projection matrix to aid in debugging.WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp: Modified theupdateTrackablemethod to call the newcomputeGLviewMatrixmethod with the current pose, ensuring the GL view matrix is updated accordingly.Minor changes:
WebARKit/WebARKitTrackers/WebARKitOpticalTracking/WebARKitTracker.cpp: Removed an unnecessary line break in the class definition.