refactor(#50): remove dead stub + commented-out scaffolding#57
Merged
Conversation
update() was declared in the header but never defined or called (the live per-frame path is processFrameData()). It only linked because nothing referenced it; calling it would have been a link error. Not scaffolding -- a future update() would be declared with its implementation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
im_gray() was a fully commented-out grayscale routine in WebARKitUtils.h, superseded by convert2Grayscale(). Pure dead text (git history retains it). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Remove the commented-out multi-marker _trackables[...] lines (the old artoolkitX-style forms left beside their live single-marker replacements) and the commented getPoseMatrix3 declarations. Comment-only; the live code and explanatory comments are untouched, so the compiled output is identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added
enhancement
kalwalt
moved this from Review in progress
to Reviewer approved
in New markerless image tracking
github-project-automation
Bot
moved this from Reviewer approved
to Done
in New markerless image tracking
kalwalt
added a commit
to webarkit/webarkit-testing
that referenced
this pull request
Jun 20, 2026
…isions Companion to webarkit/WebARKitLib#57. Bump the submodule to the cleanup commits (remove update() stub, im_gray(), commented _trackables/getPoseMatrix3) and rebuild build/ + dist/ (emscripten output is not byte-reproducible, so the artifacts change even for a behavior-neutral source edit). docs/audit-dead-code-issue50.md: add a "Decisions & status" section recording what was removed in #57 and what was deliberately KEPT (OCVT-derived symbols for ArtoolkitX parity, _trackVizActive scaffolding, and plausible WebARKit API / accessors / config constants), plus the one pending item (computePose cluster). Verified: static (pyrLevel 1) and webcam (pyrLevel 0) examples both track, 1000 matches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4 tasks
kalwalt
added a commit
to webarkit/webarkit-testing
that referenced
this pull request
Jun 21, 2026
…isions Companion to webarkit/WebARKitLib#57. Bump the submodule to the cleanup commits (remove update() stub, im_gray(), commented _trackables/getPoseMatrix3) and rebuild build/ + dist/ (emscripten output is not byte-reproducible, so the artifacts change even for a behavior-neutral source edit). docs/audit-dead-code-issue50.md: add a "Decisions & status" section recording what was removed in #57 and what was deliberately KEPT (OCVT-derived symbols for ArtoolkitX parity, _trackVizActive scaffolding, and plausible WebARKit API / accessors / config constants), plus the one pending item (computePose cluster). Verified: static (pyrLevel 1) and webcam (pyrLevel 0) examples both track, 1000 matches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First (and minimal) cleanup from the #50 audit. Behavior-neutral — only a dead declaration and commented-out text are removed, so the compiled WASM is byte-identical (no rebuild needed). Three commits:
WebARKitManager::update()— declared in the header but never defined or called (the live per-frame path isprocessFrameData()). It only linked because nothing referenced it. Removed.im_gray()— a fully commented-out grayscale routine inWebARKitUtils.h, superseded byconvert2Grayscale(). Removed._trackables[…]/getPoseMatrix3lines — the old multi-marker forms left beside their live single-marker replacements, plus the commentedgetPoseMatrix3decls. Removed; live code and explanatory comments untouched (brace balance verified 135/135).Scope note (per audit discussion)
After cross-checking ArtoolkitX OCVT, we deliberately kept everything with plausible future value rather than chasing maximal deletion:
CleanUp— used by ArtoolkitXRemoveAllMarkers;GetAllFeatures,IsSelected,markerRoi,inlier_matches) — kept for parity / possible future use._trackVizActive/TrackerVisualization— kept as scaffolding for a future debug overlay.getWebARKitVersion,getTracker,getDistortionCoefficients, the cv::Mat overloads, the BCD version API,N,featureDetectPyramidLevel) — kept as plausible API surface.So this PR removes only un-restorable-value noise. The KEEP decisions are being recorded in the companion webarkit-testing audit doc.
Refs #50.
🤖 Generated with Claude Code