feat(wasm): finalize calib3d bindings and tests#55
Merged
Conversation
Agent-Logs-Url: https://github.com/webarkit/purecv/sessions/38005598-60bc-4ebd-967c-f0aa8ac3425f Co-authored-by: kalwalt <1275858+kalwalt@users.noreply.github.com>
Agent-Logs-Url: https://github.com/webarkit/purecv/sessions/38005598-60bc-4ebd-967c-f0aa8ac3425f Co-authored-by: kalwalt <1275858+kalwalt@users.noreply.github.com>
…_pnp_ransac Agent-Logs-Url: https://github.com/webarkit/purecv/sessions/5fc1b86e-5d0e-46ea-a26c-d3af094c49f6 Co-authored-by: kalwalt <1275858+kalwalt@users.noreply.github.com>
…ments Agent-Logs-Url: https://github.com/webarkit/purecv/sessions/5fc1b86e-5d0e-46ea-a26c-d3af094c49f6 Co-authored-by: kalwalt <1275858+kalwalt@users.noreply.github.com>
- Add robust error handling and strict flag checks in PnP - Enforce 6-point minimum bounds for DLT PnP - Normalize reprojection thresholds by focal lengths - Improve singular matrix handling in undistort_points - Add tests covering SVD, homography, and PnP functionality Closes #51
- Fix SolvePnPMethod enum mapping for WASM bindings - Provide type-safe access via DynamicMatrix enhancements - Enable and update Node.js-based WASM integration tests - Suppress too_many_arguments clippy warnings on exported WASM functions - Update crates/wasm/README.md with new calib3d coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR finalizes the WASM bindings for the
calib3dmodule, enabling camera calibration and 3D geometry processing in WebAssembly environments.Key Additions & Fixes
solvePnP,solvePnPRansac,findHomography, androdriguesfor JS/TS environments.SolvePnPMethodvariants.as_matrix_f64_mutinDynamicMatrixto allow safe, mutable memory access across the FFI boundary forMatrix<f64>.crates/wasm/tests/web.rsto validatecalib3dfunctionalities using the Node.js test environment, constructing synthetic tests with non-coplanar points for numerical stability.crates/wasm/README.mdto indicate coverage of thecalib3dmodule.Closes #53