Skip to content

[codex] Focus social media downloads on active media#113

Merged
esokullu merged 8 commits into
mainfrom
download_social_media_improved
Jun 1, 2026
Merged

[codex] Focus social media downloads on active media#113
esokullu merged 8 commits into
mainfrom
download_social_media_improved

Conversation

@esokullu

@esokullu esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make download_social_media default to the focused/open media item instead of sweeping whole social feeds
  • add focused media scoring for dialogs, lightboxes, single posts, and centered viewport media in both Chrome and Firefox builds
  • keep explicit bulk downloads available via mode:"all" or scroll:true, and default extension-triggered focused requests to limit: 1
  • preserve video intent by preferring signed HTTP video URLs, then focused/main blob: video URLs, then image/poster fallback
  • keep the live SMD test-runner copy synced with the Chrome implementation
  • add deterministic fixtures for Instagram, YouTube, and X modal-vs-feed behavior

Validation

  • npm test (236 passed, 0 failed)
  • npm run test:fixtures (10 passed, 0 failed)
  • node --check on changed JS/MJS files including test/smd-tests/social-media-downloader.js
  • git diff --check
  • py test/smd-tests/test_smd.py --site recommendation_builder --headless
  • SHA-256 equality check between src/chrome/src/agent/social-media-downloader.js and test/smd-tests/social-media-downloader.js

@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webbrain Ready Ready Preview, Comment Jun 1, 2026 1:42am

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d274f9f01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/chrome/src/agent/social-media-downloader.js Outdated

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Addressed the focused blob video feedback in 7a0761c: focused mode now keeps a focused blob: video ahead of its poster image, with a regression fixture for the Instagram reel/dialog case.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a0761c94c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/chrome/src/agent/social-media-downloader.js

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Addressed the YouTube focused-download feedback in 78b38aa: focused mode now prefers signed/fetchable HTTP video URLs first, then focused blob: video URLs, then poster/image fallback. Added a YouTube regression fixture alongside the Instagram blob fixture.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78b38aa2af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/chrome/src/agent/social-media-downloader.js

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Addressed the forced mode:"main" feedback in b866b68: main-mode results now order HTTP videos first, then blob videos, then posters/images without collapsing the result list. Added a regression fixture for main-mode blob video plus poster under a one-download caller limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b866b687cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test/smd-tests/sites.py

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Addressed the live SMD runner copy feedback in 6b575aa: synced test/smd-tests/social-media-downloader.js from the Chrome implementation, verified the default test_smd.py path without --js, and added a hash equality check between the two copies.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex pls check again

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Added the visible-media crop fallback in d190536. Please check again.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Follow-up fix in 5f14039 keeps screenshot-crop downloads as .png filenames. Please check the latest head again.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f140399cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/chrome/src/agent/social-media-downloader.js

esokullu commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Addressed the extensionless HTTP-video filename feedback in 4f01d17: the downloader now reuses the HTTP-video predicate when choosing video vs photo filenames, with Chrome/Firefox/live-test copy sync and regression coverage. Please check again.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@esokullu esokullu merged commit 5e390e1 into main Jun 1, 2026
2 checks passed
@esokullu esokullu deleted the download_social_media_improved branch June 1, 2026 02:16
esokullu added a commit that referenced this pull request Jul 13, 2026
esokullu added a commit that referenced this pull request Jul 13, 2026
Merge pull request #113 from webbrain-one/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant