fix(media): require LinkedIn permalink IDs - #2684
Merged
esokullu merged 1 commit intoAug 5, 2026
Merged
Conversation
|
@alectimison-maker is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens LinkedIn permalink detection so container paths require visual resolution while concrete posts retain direct downloads.
Changes:
- Require identifiers after both supported LinkedIn permalink prefixes.
- Add Chrome/Firefox coverage for direct and empty permalink paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/run.js |
Tests direct and empty LinkedIn permalinks. |
src/firefox/src/agent/public-media-url.js |
Requires a LinkedIn post identifier. |
src/chrome/src/agent/public-media-url.js |
Mirrors the Firefox URL validation change. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/posts/and/feed/update/prefixesProblem
isDirectPublicMediaUrltreated the bare/posts/and/feed/update/paths as concrete public media items. Recommended downloads therefore skipped visual target resolution and could send a non-item URL todownload_public_media.LinkedIn's documented
/feed/update/<activityUrn>permalink shape requires a dynamic identifier: https://learn.microsoft.com/en-us/linkedin/marketing/community-management/shares#constructing-permalinksTesting
node test/run.js: 1449 passed, 1 pre-existing repository failure (package.jsonis26.0.10, newestCHANGELOG.mdentry is26.0.0)node test/security/injection-corpus.mjs: 60/60 checks passed/posts/and/feed/update/paths start with screenshot preflight/posts/<id>and/feed/update/<activityUrn>retain the direct fast pathScope
This only tightens LinkedIn's two existing permalink patterns; no other host recognition or download behavior changes.