fix: dedupe run progress replay-gap notices - #2753
Merged
webbrain-one merged 1 commit intoAug 11, 2026
Merged
Conversation
|
@alectimison-maker is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents duplicate replay-gap notices as acknowledgement boundaries advance, while preserving legacy marker compatibility.
Changes:
- Uses a once-per-run replay-gap marker in both sidepanels.
- Preserves deduplication for restored legacy markers.
- Adds cross-browser regression coverage for advancing boundaries.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/run.js |
Updates and extends replay-gap regression tests. |
src/firefox/src/ui/sidepanel.js |
Implements Firefox notice deduplication. |
src/chrome/src/ui/sidepanel.js |
Implements Chrome notice deduplication. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
When another panel acknowledges events while a displayed run remains behind,
ackedSeqcan advance across state polls whilelastRenderedSeqstays unchanged. The previous boundary-based marker treated every larger boundary as a new gap and appended the same notice repeatedly.Closes #2750.
Design
The marker now records whether the run's assistant message has shown a replay-gap notice, instead of recording the largest unavailable sequence. The rendered-event cursor is intentionally unchanged so acknowledged terminal snapshots can still restore
finalContent. Restored HTML carrying the previousdata-replay-gap-before-seqmarker is treated as already notified.Chrome and Firefox use the same implementation.
Testing
npm test— passnpm run test:webmcp— both functional smoke phases pass locally; the process then times out in CDP cleanup. The identical cleanup timeout reproduces on an unmodifiedupstream/main@41941bf3worktree.Compatibility and risks
Low risk. This is UI-only state on the existing assistant message element. It does not change the run journal, acknowledgement behavior, protocol, model prompts, permissions, or persisted data schema.
Scope
Changed only the mirrored Chrome/Firefox sidepanel replay-gap branch and its existing regression tests.