feat: render markdown tables in sidepanel and skill previews - #2845
Open
snowyukitty wants to merge 1 commit into
Open
feat: render markdown tables in sidepanel and skill previews#2845snowyukitty wants to merge 1 commit into
snowyukitty wants to merge 1 commit into
Conversation
- Implement pure ES GFM table renderer in markdown-render.js supporting column alignment, single edge pipes, delimiter hyphens (>=3), and escaped pipes - Centralize anchor-protected inline formatting with collision-safe sentinels across all placeholder families - Support dot and parenthesized ordered list numbers at post-table block boundaries - Trim trailing whitespace line breaks cleanly - Maintain byte-for-byte implementation parity across Chrome and Firefox builds - Add comprehensive test coverage in test/run.js
|
@snowyukitty is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
thanks for the contribution @snowyukitty i think it's conflicting with an earlier commit but it can stilll merge into skills block - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for rendering GitHub Flavored Markdown (GFM) tables in both the sidepanel chat UI and the skill preview pane across Chrome and Firefox builds (addressing #2838).
Key Highlights
Pure ES Table Renderer (
markdown-render.js):<div class="markdown-table-wrapper"><table>...</table></div>).:---,:---:,---:), single edge pipes, escaped pipes (\|), and GFM delimiter hyphen validation (>= 3).-/*/+and dot/parenthesized numbered lists1./1)), blockquotes, and ATX headings containing pipes.Protected Inline Formatting & Collision-Safe Sentinels:
renderInlineMarkdownto protect sanitized markdown anchors with unique sentinels during emphasis processing, preserving starred URLs and supporting bold/italic both around and inside link text.CODE,INLINE,TABLE,LINK,QUOTE,LIST).Parity & Comprehensive Testing:
Closes #2838