Conversation
mikeprimm
added a commit
that referenced
this pull request
Jun 13, 2011
Add better HTTP proxy support for webchat, add hidewebchatip option to alias web chat IP addresses
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for using X-Forwarded-From header (passed by most HTTP proxies) to get original client address when a proxy has forwarded a web request (as is the case in our example apache2 configuration).
Also, added option on internal and JSON update handlers to hide IP address of web chat (substituting the IP address with a sequentially generated alias - 'web-###' - based on user request. IP address is still used as correlator, but is not shown in the reported chat messages.