fix #1051 Converting PNGs to JPEG#1052
Merged
miketaylr merged 1 commit intowebcompat:masterfrom May 19, 2016
Merged
Conversation
| if self.image_object.format in ['JPEG', 'JPG', 'JPE', 'PNG']: | ||
| save_parameters['optimize'] = True | ||
| # Convert PNG to JPEG. See issue #1051 | ||
| file_dest = 'jpg'.join(file_dest.rsplit('png', 1)) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Member
|
I think we should go for it -- I'll merge and test on staging. |
| @@ -86,6 +86,8 @@ def save(self): | |||
| # Optimize further the image compression for these formats | |||
| if self.image_object.format in ['JPEG', 'JPG', 'JPE', 'PNG']: | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @miketaylr
This convert the PNG to JPEG for optimizing the size and the time, and bypass the issue with PNG poor encoding performances.
This is not necessary to integrate. but it would be worth testing at least. This is a simple fix following up my tests in #1051