Renamed NewCollection to NeedsTriageCollection#1202
Renamed NewCollection to NeedsTriageCollection#1202miketaylr merged 1 commit intowebcompat:masterfrom
Conversation
miketaylr
left a comment
miketaylr
left a comment
There was a problem hiding this comment.
Can you make the changes consistent in the other places where NewFoo was used?
Thanks!
| diagnose.NeedsTriageCollection = Backbone.Collection.extend({ | ||
| model: issues.Issue, | ||
| url: '/api/issues/category/needstriage' | ||
| }); |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Can you also update the commit message according to the contribution guidelines? https://github.com/webcompat/webcompat.com/blob/master/CONTRIBUTING.md#submission-guidelines Thanks! |
|
@haseebgit let me know if you need any help with this! ❤️ |
|
@miketaylr I have some doubts, I will ping you on IRC |
Sure thing, feel free to ask questions here in the issue as well. |
|
@miketaylr i edited this through web and now finding it difficult to update the PR, should i delete this branch and create new PR from my machine? |
|
@haseebgit as long as you're editing the files on the "patch-1" branch, it should be possible from the web (and should automatically update the PR). (But it might be good to make edits locally, to verify that it still works after you make the changes. Let me know if you need help getting it running.) |
|
@miketaylr r? |
| <div id="js-lastIssue"> | ||
| <script type="text/template" id="new-tmpl"> | ||
| <script type="text/template" id="needstriage-tmpl"> | ||
| <% if (newIssues.length) { %> |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@haseebgit check out this article on syncing your fork with upstream, your current repo is out of date: https://help.github.com/articles/syncing-a-fork/ |
|
Thanks! |
2 participants
r? @miketaylr