Fixes #982. Upgrade Intern to 3.4.0 by miketaylr · Pull Request #1277 · webcompat/webcompat.com

miketaylr · 2017-01-11T16:03:43Z

get it working
update docs
update travis
fix failing tests

Not ready for review yet.

miketaylr · 2017-01-11T16:26:07Z

FYI @karlcow, this is working on my machine™, so you might wait until this is merged to not have to downgrade libs or browsers to run tests locally.

karlcow · 2017-01-12T00:23:28Z

❤️ Thanks

miketaylr · 2017-01-12T09:03:52Z

It seems like there's a few tests that are broken now, as a result of changes in either how Intern is working, or Selenium or something. Will try to fix these ASAP and get this merged, this is a major win in terms of simplifying dev environment setup.

miketaylr · 2017-01-14T00:08:31Z

Locally:

Fx 50 MAC:  [✓✓✓✓✓✓✓✓✓✓✓×✓✓✓×✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓×✓✓✓✓✓] 68/68, 3 fail

Getting there.

miketaylr · 2017-01-14T04:25:47Z

Hmm... 18/68 tests failed. There's some timing differences it seems that I don't understand w/ Intern 3. Things are green locally, but the travis linux VMs either timeout or race.

miketaylr · 2017-01-14T05:08:02Z

43e593d is dumb. But...

5/68 tests failed

There seems to be different behavior when Intern commands "cross" page loads. Like they execute too quickly, or something.

miketaylr · 2017-01-27T20:13:28Z

OK, this is too flaky. @vladikoff said he would help me debug when we're in Mountain View next week.

miketaylr · 2017-02-02T05:16:23Z

OK, this is too flaky. @vladikoff said he would help me debug when we're in Mountain View next week.

We found out there was a bug in my login method that didn't surface w/ Intern 2 -- if we get the extra confirmation page from GitHub, you have to click on a button. In Intern 3, it's clicking on it sometimes too quickly (so possibly we were clicking on the original submit twice, rather than once on submit, then once on confirmation).

Also we have a theory that if you click on a button too quickly, GitHub thinks you're a bot. So, we added a small timeout if you see that extra confirmation page.

Anyways, let's see if the tests actually pass now for both runs.

miketaylr · 2017-02-02T05:22:10Z

All checks have passed

Let's retrigger.

magsout · 2017-02-02T05:33:28Z

Also we have a theory that if you click on a button too quickly, GitHub thinks you're a bot. So, we added a small timeout if you see that extra confirmation page.

Good catch... hard to find this bug...

vladikoff · 2017-02-02T05:34:43Z

@magsout hey man, how is it going!? 🥇

…more.

…or a loaded DOM element.

…pers.js. Before, when Intern was injecting the code to postMessage blobs, Firefox was throwing an x-ray wrapper permission error, which killed the test. Presumably this is related to how WebDriver/Intern injects the JS test files. As a test-only workaround, make it possible to load a test helper file so methods can be called trusted content.

miketaylr · 2017-02-02T06:34:29Z

r? @karlcow -- not much that's interesting to review in the test re-writes, mostly in the docs and the Python bits.

karlcow

Assuming that @vladikoff reviewed the JS with you.
Very very cool to have a helper.js where the functions are defined, thats simplifies a lot the tests code. ❤️

CONTRIBUTING.md

 The js folder contains two subfolders: `lib` contains all project source files and `vendor` contains all third party libraries. The files out of the two sub folders contain the compiled source code.

-__Note: All code changes should be made to the files in `lib`__
+> Note: All code changes should be made to the files in `lib`


CONTRIBUTING.md

-Windows typically doesn't have the *make* tool installed. Windows users without *make* should look at the "detailed setup" section below.
-
-As an alternative to Windows, a cloud IDE such as [Cloud 9](https://c9.io) can be used for a relatively easier setup. If you take this route, please update to the latest Python version with the following. (This is to avoid `InsecurePlatformWarning` errors that arise when the default Python 2.7.6 is used).
+> Note: If you install Python on Windows using the MSI installer, it is highly recommended to check the "Add to path"-box during installation. If you have not done so, see if one of the answers to the StackOverflow post [Adding Python path on Windows 7](http://stackoverflow.com/questions/6318156/adding-python-path-on-windows-7) can help you - it should also work fine for later versions of Windows.


tests/functional/comments-auth.js

-        .then(function(isDisplayed) {
-          assert.equal(isDisplayed, true, 'Comment form visible for logged in users.');
-        })
+      return FunctionalHelpers.openPage(this, url('/issues/100'), '.js-Issue')


tests/functional/image-uploads-non-auth.js

  'use strict';

-  var url = intern.config.siteRoot;
+  var url = intern.config.siteRoot + '/?open=1';


karlcow · 2017-02-02T07:08:10Z

And given that github markdown strips the style attribute let's roll it. 🎢

magsout · 2017-02-02T07:13:26Z

@vladikoff hey, fine and you ?

miketaylr · 2017-02-02T16:42:58Z

Thanks @karlcow @vladikoff!

miketaylr added the status: in progress label Jan 11, 2017

miketaylr force-pushed the issues/982/1 branch 3 times, most recently from 2c1b668 to 76945fe Compare January 11, 2017 16:14

miketaylr force-pushed the issues/982/1 branch 6 times, most recently from d708bb8 to ec1f750 Compare January 11, 2017 21:55

karlcow mentioned this pull request Jan 12, 2017

Re-land "Handle two sizes images" feature #1271

Closed

3 tasks

miketaylr force-pushed the issues/982/1 branch from ec1f750 to 3609a1a Compare January 13, 2017 23:40

Issue #982. Upgrade to Intern 3.4.0.

df35a19

miketaylr force-pushed the issues/982/1 branch 2 times, most recently from 51b731a to b8af369 Compare January 13, 2017 23:52

miketaylr force-pushed the issues/982/1 branch from 3934c7c to 54b662e Compare January 14, 2017 03:57

miketaylr force-pushed the issues/982/1 branch 2 times, most recently from 8f8ce5f to 647432f Compare January 14, 2017 04:46

miketaylr force-pushed the issues/982/1 branch 6 times, most recently from d795e75 to 595177e Compare January 15, 2017 00:58

miketaylr force-pushed the issues/982/1 branch 3 times, most recently from 3d6c1ea to 9f748b8 Compare January 27, 2017 05:34

karlcow mentioned this pull request Jan 27, 2017

Upgrade Flask to 0.12 #1304

Closed

miketaylr force-pushed the issues/982/1 branch 4 times, most recently from 6571844 to 7f022a7 Compare January 27, 2017 19:54

miketaylr force-pushed the issues/982/1 branch from 7f022a7 to 6a0b648 Compare February 2, 2017 05:12

Mike Taylor added 6 commits February 1, 2017 21:48

Issue #982. Update docs on how to run Intern.

8cadb0c

Issue #982. Update Travis configs to not need standalone selenium any…

36749aa

…more.

Issue #982. Intern 3 wants paths to real files.

8d70512

Issue #982. Use FunctionalHelpers.visibleByQSA when wanting to wait f…

fe9b6c2

…or a loaded DOM element.

Issue #982. Use WindowHelpers blob methods in upload tests.

b5db42c

miketaylr force-pushed the issues/982/1 branch from 6a0b648 to 2df30ca Compare February 2, 2017 05:48

Issue #982. Fix tests that fail in Intern 3, that didn't in Intern 2.

904941e

miketaylr force-pushed the issues/982/1 branch from 2df30ca to 904941e Compare February 2, 2017 06:04

karlcow approved these changes Feb 2, 2017

View reviewed changes

karlcow merged commit 2ac4caf into master Feb 2, 2017

karlcow removed the status: in progress label Feb 2, 2017

Conversation

miketaylr commented Jan 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miketaylr commented Jan 11, 2017

Uh oh!

karlcow commented Jan 12, 2017

Uh oh!

miketaylr commented Jan 12, 2017

Uh oh!

miketaylr commented Jan 14, 2017

Uh oh!

miketaylr commented Jan 14, 2017

Uh oh!

miketaylr commented Jan 14, 2017

Uh oh!

miketaylr commented Jan 27, 2017

Uh oh!

miketaylr commented Feb 2, 2017

Uh oh!

miketaylr commented Feb 2, 2017

Uh oh!

magsout commented Feb 2, 2017

Uh oh!

vladikoff commented Feb 2, 2017

Uh oh!

miketaylr commented Feb 2, 2017

Uh oh!

karlcow left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

karlcow commented Feb 2, 2017

Uh oh!

magsout commented Feb 2, 2017

Uh oh!

miketaylr commented Feb 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

miketaylr commented Jan 11, 2017 •

edited

Loading