Fixes #1377 - Document importance of running grunt or npm build#1380
Fixes #1377 - Document importance of running grunt or npm build#1380zoepage merged 1 commit intowebcompat:masterfrom
Conversation
5805ff5 to
46d0307
Compare
|
r? @miketaylr (I submitted first and it failed the Travis build but...the only thing I changed was the contributing.md file, so I added |
|
@heatherbooker There is an almost finished PR that is fixing a few issues. (Thank you for all of your contributions && your time. You rock!!!) |
|
Awesome, thanks @heatherbooker! I just unintentionally created a merge conflict for you, but I can help fix that if you'd like. |
46d0307 to
7d57db1
Compare
|
Ah ok thanks for the heads up @zoepage ! @miketaylr Ok so you would still like to include these changes? I think I resolved the merge conflict. I'm glad grunt has become a local dependency :) |
|
@heatherbooker yeah, I still think it's a good contribution. But let me pass off review to @zoepage, since she's been knee-deep in that recently. |
zoepage
left a comment
There was a problem hiding this comment.
Great additional info. Thank you :)
|
:) |
Hopefully this fixes #1377 !
jeanhl had css problems running functional tests because of missing out on running grunt, and I had css problems viewing the site locally - this patch should clarify the importance of having grunt and running
gruntornpm run buildbefore moving on to bigger and better things! :)