Skip to content

Fixes #1377 - Document importance of running grunt or npm build#1380

Merged
zoepage merged 1 commit intowebcompat:masterfrom
heatherbooker:emphasizeGrunt
Mar 6, 2017
Merged

Fixes #1377 - Document importance of running grunt or npm build#1380
zoepage merged 1 commit intowebcompat:masterfrom
heatherbooker:emphasizeGrunt

Conversation

@heatherbooker
Copy link
Copy Markdown
Contributor

Hopefully this fixes #1377 !

jeanhl had css problems running functional tests because of missing out on running grunt, and I had css problems viewing the site locally - this patch should clarify the importance of having grunt and running grunt or npm run build before moving on to bigger and better things! :)

@heatherbooker
Copy link
Copy Markdown
Contributor Author

r? @miketaylr

(I submitted first and it failed the Travis build but...the only thing I changed was the contributing.md file, so I added [ci skip] to the commit msg...I'm not sure if that was the right thing to do >< .)

@zoepage
Copy link
Copy Markdown
Member

zoepage commented Mar 3, 2017

@heatherbooker There is an almost finished PR that is fixing a few issues.
Might wanna take a look here? #1351

(Thank you for all of your contributions && your time. You rock!!!)

@miketaylr
Copy link
Copy Markdown
Member

Awesome, thanks @heatherbooker! I just unintentionally created a merge conflict for you, but I can help fix that if you'd like.

@heatherbooker
Copy link
Copy Markdown
Contributor Author

Ah ok thanks for the heads up @zoepage !

@miketaylr Ok so you would still like to include these changes? I think I resolved the merge conflict. I'm glad grunt has become a local dependency :)

@miketaylr
Copy link
Copy Markdown
Member

@heatherbooker yeah, I still think it's a good contribution. But let me pass off review to @zoepage, since she's been knee-deep in that recently.

@miketaylr miketaylr requested a review from zoepage March 3, 2017 21:40
Copy link
Copy Markdown
Member

@zoepage zoepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additional info. Thank you :)

@heatherbooker
Copy link
Copy Markdown
Contributor Author

:)

@karlcow karlcow changed the title Issue #1377: Document importance of running grunt or npm build Fixes #1377 - Document importance of running grunt or npm build Mar 6, 2017
@zoepage zoepage merged commit 531c27b into webcompat:master Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document running grunt (or npm run build) before running functional tests for the first time

3 participants