Skip to content

Fixes #1375: Clarify steps to reach Github issues#1407

Merged
zoepage merged 1 commit intowebcompat:masterfrom
heatherbooker:githubLink
Mar 8, 2017
Merged

Fixes #1375: Clarify steps to reach Github issues#1407
zoepage merged 1 commit intowebcompat:masterfrom
heatherbooker:githubLink

Conversation

@heatherbooker
Copy link
Copy Markdown
Contributor

@heatherbooker heatherbooker commented Mar 7, 2017

Fixes #1375 -

  • Add octocat github button icon
  • Change wording
  • Make keyboard hint only visible on screens of width > 40em

Screenshots:

Desktop:

desktop screenshot

Mobile:

mobile screenshot

This fix, when hovering over the octocat, does not change color, unlike #1408 !

@zoepage
Copy link
Copy Markdown
Member

zoepage commented Mar 7, 2017

The changes look good to me. Just all the tests are failing. Will check again in the morning. :)

@miketaylr
Copy link
Copy Markdown
Member

Just all the tests are failing. Will check again in the morning. :)

This is a bi-product of how our testing setup works. Forks don't have access to Travis secrets, so they either can't pass the auth tests, or hit rate limits for the non-auth tests.

(Part of this Outreachy round is to find a good solution for forked contributors!)

@zoepage
Copy link
Copy Markdown
Member

zoepage commented Mar 8, 2017

@miketaylr ah, thanks for the info :)

Cool, so let's merge then :)

@zoepage zoepage merged commit 55d67b5 into webcompat:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading icon for Github view

3 participants