Fixes #1375: Clarify steps to reach Github issues#1407
Merged
zoepage merged 1 commit intowebcompat:masterfrom Mar 8, 2017
Merged
Fixes #1375: Clarify steps to reach Github issues#1407zoepage merged 1 commit intowebcompat:masterfrom
zoepage merged 1 commit intowebcompat:masterfrom
Conversation
This was referenced Mar 7, 2017
3f3a296 to
09164e9
Compare
Member
|
The changes look good to me. Just all the tests are failing. Will check again in the morning. :) |
Member
This is a bi-product of how our testing setup works. Forks don't have access to Travis secrets, so they either can't pass the auth tests, or hit rate limits for the non-auth tests. (Part of this Outreachy round is to find a good solution for forked contributors!) |
Member
|
@miketaylr ah, thanks for the info :) Cool, so let's merge then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1375 -
Screenshots:
Desktop:
Mobile:
This fix, when hovering over the octocat, does not change color, unlike #1408 !