Fixes #1662 - update whitelist for type-stylo label#1676
Merged
miketaylr merged 1 commit intowebcompat:masterfrom Jul 26, 2017
Merged
Fixes #1662 - update whitelist for type-stylo label#1676miketaylr merged 1 commit intowebcompat:masterfrom
miketaylr merged 1 commit intowebcompat:masterfrom
Conversation
tests: webcompat#1662; add funct test; skip media report tests
Member
@cch5ng if you use the edit: probably time to update my review filters... |
Member
No, not really. That information is for the triagers and will be used at triage time, rather than report time. Let's land it. |
Member
|
@cch5ng in the future, if you're making an unrelated change (the changes to tests), please include a separate commit for that. there's a number of good resources out there on "atomic commits", here's one that might be helpful: https://seesparkbox.com/foundry/atomic_commits_with_git |
miketaylr
added
status: add to changelog
and removed
in progress
status: add to changelog
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@miketaylr r?
do you think this visual usability bug matters?
#1662 (comment)
I verified that on submit, the issue gets saved with the appropriate github label so maybe it is not a big deal?